Open
Conversation
sbc100
force-pushed
the
strict_js_by_default
branch
from
8f29776 to
7053815
Compare
kripken
reviewed
Mar 9, 2026
sbc100
force-pushed
the
strict_js_by_default
branch
2 times, most recently
from
ffdf951 to
3431363
Compare
kripken
reviewed
Mar 10, 2026
kripken
reviewed
Mar 10, 2026
kripken
reviewed
Mar 10, 2026
kripken
reviewed
Mar 10, 2026
sbc100
added a commit
that referenced
this pull request
Mar 10, 2026
sbc100
force-pushed
the
strict_js_by_default
branch
2 times, most recently
from
dfd3627 to
af8de59
Compare
This has been enabled under `STRICT` mode since it was first added back in 2019 (emscripten-core#9265).
sbc100
force-pushed
the
strict_js_by_default
branch
from
af8de59 to
2f86cdf
Compare
Collaborator
Author
|
This change is now re-based onto main after #26422 landed. I'm not totally sure I want to land it .. |
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Mar 10, 2026
Its still not allowed in `EXPORT_ES6` mode where its the default. Split out from emscripten-core#26421
Member
What are the concerns? |
Collaborator
Author
I thinks its probably fine but I might let a bake a little longer. I like this it removes a whole test config. It just seems odd to be adding |
Collaborator
Author
|
I'd still like to land #26424 ASAP though. |
sbc100
added a commit
that referenced
this pull request
Mar 11, 2026
Its still not allowed in `EXPORT_ES6` mode where its the default. Split out from #26421
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has been enabled under
STRICTmode since it was first added back in 2019 (#9265).One of the benefits of enabling this by default is that we can delete the
stricttest mode and theno_strict_jsdecorator.